Open
Conversation
added 2 commits
February 17, 2026 22:18
- Update CI workflow to test both MySQL and SQLite - Add SQLite connection detection and appropriate SQL functions - Use LENGTH for SQLite vs CHAR_LENGTH for MySQL in relevance queries - Add explicit NULL to COALESCE for SQLite compatibility - Prefix model keys with underscore for SQLite identifier compatibility - Skip fullText indexes on SQLite (MySQL-only feature) - Update README to mention SQLite support Based on community PR protonemedia#58 by MeiKatz with improvements for current Laravel/PHP versions.
- Update TestCase to handle multiple database connections (sqlite, mysql, pgsql) - Fix ORDER BY issues in SQLite by using subquery approach for UNION queries - Fix MySQLGrammar hardcoding - use connection-specific query grammar - Add skip conditions for unsupported SQLite features: * JSON column operations (title->nl syntax) * SOUNDS LIKE operator * Fulltext search operations - All 35 tests now work: 31 pass, 4 correctly skip on SQLite - Maintains full backward compatibility with MySQL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds SQLite support to the cross-eloquent-search package, based on the community contribution in PR #58, updated for current Laravel/PHP versions.
Changes
Database Compatibility:
CI/Testing:
Documentation:
Testing
The CI workflow now runs a full test matrix:
SQLite tests run with :memory: database for speed and isolation.
Compatibility
Closes #58